Browse Source

improve formatting, rename and simplify vars

Jan-Peter Klein 3 months ago
parent
commit
59f360bde7

+ 14 - 6
src/main/java/org/cryptomator/ui/dialogs/Dialogs.java

@@ -15,11 +15,19 @@ public class Dialogs {
 
 	private Dialogs() {}
 
-	public static void showRemoveVaultDialog(SimpleDialog.Builder simpleDialogProvider, Stage mainWindow, Vault vault, ObservableList<Vault> vaults) {
-		simpleDialogProvider.setOwner(mainWindow).setTitleKey("removeVault.title", vault.getDisplayName()).setMessageKey("removeVault.message").setDescriptionKey("removeVault.description").setIcon(FontAwesome5Icon.QUESTION).setOkButtonKey("removeVault.confirmBtn").setCancelButtonKey("generic.button.cancel").setOkAction(v -> {
-			LOG.debug("Removing vault {}.", vault.getDisplayName());
-			vaults.remove(vault);
-			v.close();
-		}).build().showAndWait();
+	public static void showRemoveVaultDialog(SimpleDialog.Builder simpleDialogBuilder, Stage mainWindow, Vault vault, ObservableList<Vault> vaults) {
+		simpleDialogBuilder.setOwner(mainWindow) //
+				.setTitleKey("removeVault.title", vault.getDisplayName()) //
+				.setMessageKey("removeVault.message") //
+				.setDescriptionKey("removeVault.description") //
+				.setIcon(FontAwesome5Icon.QUESTION) //
+				.setOkButtonKey("removeVault.confirmBtn") //
+				.setCancelButtonKey("generic.button.cancel") //
+				.setOkAction(v -> {
+					LOG.debug("Removing vault {}.", vault.getDisplayName());
+					vaults.remove(vault);
+					v.close();
+				}) //
+				.build().showAndWait();
 	}
 }

+ 1 - 2
src/main/java/org/cryptomator/ui/dialogs/SimpleDialog.java

@@ -32,7 +32,6 @@ public class SimpleDialog {
 
 		FxmlLoaderFactory loaderFactory = FxmlLoaderFactory.forController(new SimpleDialogController(), Scene::new, builder.resourceBundle);
 		FXMLLoader loader = loaderFactory.load(FxmlFile.SIMPLE_DIALOG.getRessourcePathString());
-		Parent root = loader.getRoot();
 		SimpleDialogController controller = loader.getController();
 
 		controller.setMessage(resolveText(builder.messageKey, null));
@@ -44,7 +43,7 @@ public class SimpleDialog {
 		controller.setOkAction(() -> builder.okAction.accept(dialogStage));
 		controller.setCancelAction(() -> builder.cancelAction.accept(dialogStage));
 
-		dialogStage.setScene(new Scene(root));
+		dialogStage.setScene(new Scene(loader.getRoot()));
 	}
 
 	public void showAndWait() {