瀏覽代碼

Applied suggestions from code review

Changed signature of afterExecuteTask
See: https://github.com/cryptomator/cryptomator/pull/2259/files#r875548549

--

Changed name of "afterExecute0" to "afterExecuteInternal"
See: https://github.com/cryptomator/cryptomator/pull/2259/files#r875551994
JaniruTEC 2 年之前
父節點
當前提交
f740a93b6c
共有 1 個文件被更改,包括 6 次插入5 次删除
  1. 6 5
      src/main/java/org/cryptomator/common/CatchingExecutors.java

+ 6 - 5
src/main/java/org/cryptomator/common/CatchingExecutors.java

@@ -31,7 +31,7 @@ public final class CatchingExecutors {
 		@Override
 		protected void afterExecute(Runnable runnable, Throwable throwable) {
 			super.afterExecute(runnable, throwable);
-			afterExecute0(runnable, throwable);
+			afterExecuteInternal(runnable, throwable);
 		}
 	}
 
@@ -44,15 +44,15 @@ public final class CatchingExecutors {
 		@Override
 		protected void afterExecute(Runnable runnable, Throwable throwable) {
 			super.afterExecute(runnable, throwable);
-			afterExecute0(runnable, throwable);
+			afterExecuteInternal(runnable, throwable);
 		}
 	}
 
-	private static void afterExecute0(Runnable runnable, Throwable throwable) {
+	private static void afterExecuteInternal(Runnable runnable, Throwable throwable) {
 		if (throwable != null) {
 			callHandler(Thread.currentThread(), throwable);
 		} else if (runnable instanceof Task<?> t) {
-			afterExecuteTask(Thread.currentThread(), t);
+			afterExecuteTask(t);
 		} else if (runnable instanceof Future<?> f) {
 			afterExecuteFuture(f);
 		}
@@ -67,7 +67,8 @@ public final class CatchingExecutors {
 		return (thread, throwable) -> LOG.error("FALLBACK: Uncaught exception in " + thread.getName(), throwable);
 	}
 
-	private static void afterExecuteTask(Thread caller, Task<?> task) {
+	private static void afterExecuteTask(Task<?> task) {
+		var caller = Thread.currentThread();
 		Platform.runLater(() -> {
 			if (task.getOnFailed() == null) {
 				callHandler(caller, task.getException());